fix: guard rename/update_url actions against empty remote list#2870
fix: guard rename/update_url actions against empty remote list#2870extrawurst merged 3 commits intogitui-org:masterfrom
Conversation
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
extrawurst
left a comment
extrawurst
left a comment
There was a problem hiding this comment.
Thanks for your contribution. looks good to me. Please add a changelog entry and we are gtg
xvchris
force-pushed
the
fix/remotelist-panic-no-remotes
branch
3 times, most recently
from
30acb93 to
5bbe31f
Compare
|
Hi @extrawurst, the changelog entry was already added in commit 25ab784. Please take another look when you get a chance! 🙏 |
|
Hi! The changelog entry has already been added in the PR: Let me know if anything else is needed, happy to adjust! |
The rename_remote() and update_remote_url() event handlers in RemoteListPopup did not check valid_selection() before indexing into self.remote_names, causing a panic (index out of bounds) when no remotes are configured. The delete_remote() handler already had this guard. This commit adds the same valid_selection() check to the other two handlers for consistency. Fixes gitui-org#2868 Fixes gitui-org#2869
xvchris
force-pushed
the
fix/remotelist-panic-no-remotes
branch
from
e3ac866 to
14755a8
Compare
|
Thanks for the review, @alerque! I've resolved the merge conflict in CHANGELOG.md — the branch was rebased onto the current master, incorporating the |
3 participants
This Pull Request fixes/closes #2868, #2869.
It changes the following:
valid_selection()guard torename_remoteevent handler branchvalid_selection()guard toupdate_remote_urlevent handler branch## Unreleased→### FixesThese guards match the existing pattern on
delete_remote, preventing an index-out-of-bounds panic when the remote list is empty.I followed the checklist:
RemoteListPopuphas no existing test infrastructure (new()requires fullEnvironment); the fix is a 2-line guard addition matching the existingdelete_remotepatternmake checkwithout errors